diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2026-10-19 17:45:32 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2026-10-20 10:47:29 +0200 |
| commit | 931f5714b7921290cd1a4742e185aeeae7270ee6 (patch) | |
| tree | 811986aa8151686ba676893da964fdf625ab937b /scripts/Makefile.thinlto | |
| parent | 82da1acad6fd60b6072dd5f3383e6a55efdd2ac7 (diff) | |
| download | linux-931f5714b7921290cd1a4742e185aeeae7270ee6.tar.gz linux-931f5714b7921290cd1a4742e185aeeae7270ee6.zip | |
ALSA: compress: add missing OPEN-state gate to SET_METADATA
snd_compr_set_metadata() calls stream->ops->set_metadata() straight
after copy_from_user(), without ever checking runtime->state, even
though the function's own comment says a parameter change should only
be allowed once the stream has left the OPEN state. Every other
metadata/param entry point in this file (SET_PARAMS, WRITE, ...)
enforces that gate.
A codec driver's set_metadata callback can assume SET_PARAMS has
already run and initialised its private state; calling it while the
stream is still OPEN can operate on that uninitialised state.
Add the OPEN-state check the existing comment already documents.
Fixes: 9727b490e543 ("ALSA: compress: add support for gapless playback")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Link: https://patch.msgid.link/20261019144533.30665-4-peter.ujfalusi@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
