diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2026-10-19 17:45:31 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2026-10-20 10:47:14 +0200 |
| commit | 82da1acad6fd60b6072dd5f3383e6a55efdd2ac7 (patch) | |
| tree | b612afe66e7d611cea528af7014829525f4d2d29 /scripts/Makefile.thinlto | |
| parent | fbc74ca9fbf7e0b8f6872ccac62f9f4a1f3b5e53 (diff) | |
| download | linux-82da1acad6fd60b6072dd5f3383e6a55efdd2ac7.tar.gz linux-82da1acad6fd60b6072dd5f3383e6a55efdd2ac7.zip | |
ALSA: compress: reject buffer geometry change on gapless next_track
snd_compr_set_params() is invoked from the gapless next_track
re-entry path, which calls snd_compr_allocate_buffer() again and lets
buffer_size change while total_bytes_available and
total_bytes_transferred still hold values computed for the previous
buffer. snd_compr_calc_avail() then derives an avail/count value from
those stale counters against the new buffer_size, and
snd_compr_write_data() copy_from_user()s that many bytes into the
new, potentially smaller buffer, overflowing it with user-controlled
length and content.
The buffer is set up once, with the initial SET_PARAMS, and neither the
core nor the DSP expects it to change for a gapless track transition.
Do not call snd_compr_allocate_buffer() on the next_track path and
reject a request that changes the buffer geometry, so that the codec
parameters that the driver receives match the buffer in use.
Fixes: 9727b490e543 ("ALSA: compress: add support for gapless playback")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://patch.msgid.link/20261019144533.30665-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
