diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2021-12-15 11:24:50 -0600 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2021-12-15 11:33:22 -0600 |
| commit | 1fb466dff904e4a72282af336f2c355f011eec61 (patch) | |
| tree | ca5ff3a23b59fb239619a3ff4bc211974677ab5e /tools | |
| parent | 5eb6f22823e023ee13391978c329c4bd18f82552 (diff) | |
| download | lwn-1fb466dff904e4a72282af336f2c355f011eec61.tar.gz lwn-1fb466dff904e4a72282af336f2c355f011eec61.zip | |
objtool: Add a missing comma to avoid string concatenation
Recently the kbuild robot reported two new errors:
>> lib/kunit/kunit-example-test.o: warning: objtool: .text.unlikely: unexpected end of section
>> arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes()
I don't know why they did not occur in my test setup but after digging
it I realized I had accidentally dropped a comma in
tools/objtool/check.c when I renamed rewind_stack_do_exit to
rewind_stack_and_make_dead.
Add that comma back to fix objtool errors.
Link: https://lkml.kernel.org/r/202112140949.Uq5sFKR1-lkp@intel.com
Fixes: 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/objtool/check.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 282273a1ffa5..3fc2c57f6124 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -177,7 +177,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "fortify_panic", "usercopy_abort", "machine_real_restart", - "rewind_stack_and_make_dead" + "rewind_stack_and_make_dead", "kunit_try_catch_throw", "xen_start_kernel", "cpu_bringup_and_idle", |