diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-31 12:48:16 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-31 17:52:32 -0300 |
| commit | 9870d7809575515e26194f4b3df1750872a6ee60 (patch) | |
| tree | 43905494fe3c7724b8fe4326a4e820e897e7a7e9 /tools/perf/util/ordered-events.h | |
| parent | aae59fab978e143f24d22e52f075c4be3ee4e628 (diff) | |
| download | lwn-9870d7809575515e26194f4b3df1750872a6ee60.tar.gz lwn-9870d7809575515e26194f4b3df1750872a6ee60.zip | |
perf ordered_samples: Remove references to perf_{evlist,tool} and machines
As these can be obtained from the ordered_events pointer, via
container_of, reducing the cross section of ordered_samples.
These were added to ordered_samples in:
commit b7b61cbebd789a3dbca522e3fdb727fe5c95593f
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Tue Mar 3 11:58:45 2015 -0300
perf ordered_events: Shorten function signatures
By keeping pointers to machines, evlist and tool in ordered_events.
But that was more a transitional patch while moving stuff out from
perf_session.c to ordered_events.c and possibly not even needed by then,
as we could use the container_of() method and instead of having the
nr_unordered_samples stats in events_stats, we can have it in
ordered_samples.
Based-on-a-patch-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-4lk0t9js82g0tfc0x1onpkjt@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/ordered-events.h')
| -rw-r--r-- | tools/perf/util/ordered-events.h | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/tools/perf/util/ordered-events.h b/tools/perf/util/ordered-events.h index 173e13f28c08..f403991e3bfd 100644 --- a/tools/perf/util/ordered-events.h +++ b/tools/perf/util/ordered-events.h @@ -3,10 +3,7 @@ #include <linux/types.h> -struct perf_tool; -struct perf_evlist; struct perf_sample; -struct machines; struct ordered_event { u64 timestamp; @@ -25,8 +22,7 @@ enum oe_flush { struct ordered_events; typedef int (*ordered_events__deliver_t)(struct ordered_events *oe, - struct ordered_event *event, - struct perf_sample *sample); + struct ordered_event *event); struct ordered_events { u64 last_flush; @@ -39,13 +35,11 @@ struct ordered_events { struct list_head to_free; struct ordered_event *buffer; struct ordered_event *last; - struct machines *machines; - struct perf_evlist *evlist; - struct perf_tool *tool; ordered_events__deliver_t deliver; int buffer_idx; unsigned int nr_events; enum oe_flush last_flush_type; + u32 nr_unordered_events; bool copy_on_queue; }; @@ -53,9 +47,7 @@ int ordered_events__queue(struct ordered_events *oe, union perf_event *event, struct perf_sample *sample, u64 file_offset); void ordered_events__delete(struct ordered_events *oe, struct ordered_event *event); int ordered_events__flush(struct ordered_events *oe, enum oe_flush how); -void ordered_events__init(struct ordered_events *oe, struct machines *machines, - struct perf_evlist *evlsit, struct perf_tool *tool, - ordered_events__deliver_t deliver); +void ordered_events__init(struct ordered_events *oe, ordered_events__deliver_t deliver); void ordered_events__free(struct ordered_events *oe); static inline |