diff options
| author | Josh Poimboeuf <jpoimboe@kernel.org> | 2023-04-12 10:29:01 -0700 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2023-04-14 16:08:27 +0200 |
| commit | e18398e80c73e3cc7d9c3d2e0bc06a4af8f4f1cb (patch) | |
| tree | 1d01fae8d3ac7d1b02c260a65386b9e7036c7f81 /tools/objtool | |
| parent | f571da059f86fd9d432aea32c9c7e5aaa53245d8 (diff) | |
| download | lwn-e18398e80c73e3cc7d9c3d2e0bc06a4af8f4f1cb.tar.gz lwn-e18398e80c73e3cc7d9c3d2e0bc06a4af8f4f1cb.zip | |
Revert "objtool: Support addition to set CFA base"
Commit 468af56a7bba ("objtool: Support addition to set CFA base") was
added as a preparatory patch for arm64 support, but that support never
came. It triggers a false positive warning on x86, so just revert it
for now.
Fixes the following warning:
vmlinux.o: warning: objtool: cdce925_regmap_i2c_write+0xdb: stack state mismatch: cfa1=4+120 cfa2=5+40
Fixes: 468af56a7bba ("objtool: Support addition to set CFA base")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/oe-kbuild-all/202304080538.j5G6h1AB-lkp@intel.com/
Diffstat (limited to 'tools/objtool')
| -rw-r--r-- | tools/objtool/check.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index cae6ac6ff246..9440b07cd3b6 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3002,17 +3002,6 @@ static int update_cfi_state(struct instruction *insn, break; } - if (!cfi->drap && op->src.reg == CFI_SP && - op->dest.reg == CFI_BP && cfa->base == CFI_SP && - check_reg_frame_pos(®s[CFI_BP], -cfa->offset + op->src.offset)) { - - /* lea disp(%rsp), %rbp */ - cfa->base = CFI_BP; - cfa->offset -= op->src.offset; - cfi->bp_scratch = false; - break; - } - if (op->src.reg == CFI_SP && cfa->base == CFI_SP) { /* drap: lea disp(%rsp), %drap */ |