diff options
| author | Muhammad Usama Anjum <usama.anjum@collabora.com> | 2024-09-11 16:13:07 +0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-09-11 13:59:33 +0100 |
| commit | 5c4e15e63216e7268bb2f1132ee8fad0ec46bbb7 (patch) | |
| tree | abd7b45c03430b051ad1ee43ceca1e3a4edf1e1c /sound | |
| parent | 0b0aa67baa8904e3c1e13be48a2ca125f59ead3d (diff) | |
| download | lwn-5c4e15e63216e7268bb2f1132ee8fad0ec46bbb7.tar.gz lwn-5c4e15e63216e7268bb2f1132ee8fad0ec46bbb7.zip | |
ASoC: mediatek: mt8365: check validity before usage of i2s_data
There may be a case where i2s_data may not get initialized by the for
loop which will cause the kernel crash. Initialize the i2s_data to NULL
and abort execute if it isn't found.
Fixes: 402bbb13a195 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240911111317.4072349-1-usama.anjum@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c index 3482d8f8b4e7..11b9a5bc7163 100644 --- a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c +++ b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c @@ -465,13 +465,16 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable) int i; unsigned long flags; struct mt8365_afe_private *afe_priv = afe->platform_priv; - struct mtk_afe_i2s_priv *i2s_data; + struct mtk_afe_i2s_priv *i2s_data = NULL; for (i = 0; i < DAI_I2S_NUM; i++) { if (mt8365_i2s_priv[i].adda_link) i2s_data = afe_priv->dai_priv[mt8365_i2s_priv[i].id]; } + if (!i2s_data) + return; + spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags); if (enable) { |