diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2022-02-22 18:32:09 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-02-23 02:04:06 +0000 |
| commit | cc587b7c8fbbe128f6bd0dad025a0caea5e6d164 (patch) | |
| tree | fe204f24d9f30f2dc9767e3cbd20e52eb8794b82 /sound/soc/codecs/wcd938x.c | |
| parent | 0ea5eff7c6063a8f124188424f8e4c6727f35051 (diff) | |
| download | lwn-cc587b7c8fbbe128f6bd0dad025a0caea5e6d164.tar.gz lwn-cc587b7c8fbbe128f6bd0dad025a0caea5e6d164.zip | |
ASoC: codecs: wc938x: fix accessing array out of bounds for enum type
Accessing enums using integer would result in array out of bounds access
on platforms like aarch64 where sizeof(long) is 8 compared to enum size
which is 4 bytes.
Fix this by using enumerated items instead of integers.
Fixes: e8ba1e05bdc0 ("ASoC: codecs: wcd938x: add basic controls")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220222183212.11580-7-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/wcd938x.c')
| -rw-r--r-- | sound/soc/codecs/wcd938x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 36cbc66914f9..33d5403d4e62 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -2504,7 +2504,7 @@ static int wcd938x_tx_mode_get(struct snd_kcontrol *kcontrol, struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; int path = e->shift_l; - ucontrol->value.integer.value[0] = wcd938x->tx_mode[path]; + ucontrol->value.enumerated.item[0] = wcd938x->tx_mode[path]; return 0; } @@ -2528,7 +2528,7 @@ static int wcd938x_rx_hph_mode_get(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); - ucontrol->value.integer.value[0] = wcd938x->hph_mode; + ucontrol->value.enumerated.item[0] = wcd938x->hph_mode; return 0; } |