diff options
| author | Vijendar Mukunda <Vijendar.Mukunda@amd.com> | 2022-12-21 22:58:51 +0530 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-12-25 23:33:38 +0000 |
| commit | 966ef755d3b66853be4f15c698f5210115c15d23 (patch) | |
| tree | 3f991a7072c1f1074d2ddbe69b9f02d192297c08 /sound/soc/amd/ps/pci-ps.c | |
| parent | 9d327a4443bffe8d48acc6a31c0198f251fca08b (diff) | |
| download | lwn-966ef755d3b66853be4f15c698f5210115c15d23.tar.gz lwn-966ef755d3b66853be4f15c698f5210115c15d23.zip | |
ASoC: amd: ps: move irq handler registration
Move irq handler registration prior to platform device creation logic.
This will avoid irq handling missing scenario when platform device
raise interrrupts during it's probe sequence.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://lore.kernel.org/r/20221221172855.1618766-4-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd/ps/pci-ps.c')
| -rw-r--r-- | sound/soc/amd/ps/pci-ps.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c index 4553e81da164..401cfd0036be 100644 --- a/sound/soc/amd/ps/pci-ps.c +++ b/sound/soc/amd/ps/pci-ps.c @@ -286,6 +286,12 @@ static int snd_acp63_probe(struct pci_dev *pci, ret = acp63_init(adata->acp63_base, &pci->dev); if (ret) goto release_regions; + ret = devm_request_irq(&pci->dev, pci->irq, acp63_irq_handler, + irqflags, "ACP_PCI_IRQ", adata); + if (ret) { + dev_err(&pci->dev, "ACP PCI IRQ request failed\n"); + goto de_init; + } val = acp63_readl(adata->acp63_base + ACP_PIN_CONFIG); get_acp63_device_config(val, pci, adata); ret = create_acp63_platform_devs(pci, adata, addr); @@ -293,13 +299,6 @@ static int snd_acp63_probe(struct pci_dev *pci, dev_err(&pci->dev, "ACP platform devices creation failed\n"); goto de_init; } - ret = devm_request_irq(&pci->dev, pci->irq, acp63_irq_handler, - irqflags, "ACP_PCI_IRQ", adata); - if (ret) { - dev_err(&pci->dev, "ACP PCI IRQ request failed\n"); - goto de_init; - } - pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&pci->dev); pm_runtime_put_noidle(&pci->dev); |