diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-06-08 16:04:54 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-06-09 17:29:52 +0200 |
| commit | 13c986607f57222fcc40ad7c21df429c42b4ea02 (patch) | |
| tree | 3135142e6d9ae7cc009a98100abec66ddf7ddf6d /sound/pci/azt3328.c | |
| parent | b83bea386434208dc4d71df630eaf35b7c64166c (diff) | |
| download | lwn-13c986607f57222fcc40ad7c21df429c42b4ea02.tar.gz lwn-13c986607f57222fcc40ad7c21df429c42b4ea02.zip | |
ALSA: azt3328: Fix assignment in if condition
PCI AZT3328 driver code contains a few assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.
This patch is merely for coding-style fixes, no functional changes.
Link: https://lore.kernel.org/r/20210608140540.17885-21-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/azt3328.c')
| -rw-r--r-- | sound/pci/azt3328.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c index 51dcf1bc4c0c..4ee7ab409807 100644 --- a/sound/pci/azt3328.c +++ b/sound/pci/azt3328.c @@ -1194,7 +1194,8 @@ snd_azf3328_mixer_new(struct snd_azf3328 *chip) sw = snd_azf3328_mixer_controls; for (idx = 0; idx < ARRAY_SIZE(snd_azf3328_mixer_controls); ++idx, ++sw) { - if ((err = snd_ctl_add(chip->card, snd_ctl_new1(sw, chip))) < 0) + err = snd_ctl_add(chip->card, snd_ctl_new1(sw, chip)); + if (err < 0) return err; } snd_component_add(card, "AZF3328 mixer"); |