diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2020-01-27 10:31:07 +0100 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2020-01-27 14:25:06 -0700 |
| commit | 1630146db2111412e7524d05d812ff8f2c75977e (patch) | |
| tree | 836f54501cf31997681bcf5267570cdf099cd1fd /scripts | |
| parent | 06b9c269938ba1e9356b74584cd1ff738c0cf4de (diff) | |
| download | lwn-1630146db2111412e7524d05d812ff8f2c75977e.tar.gz lwn-1630146db2111412e7524d05d812ff8f2c75977e.zip | |
scripts/find-unused-docs: Fix massive false positives
scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a
source file contains kerneldoc or not.
However, as it passes the no longer supported "-text" option to
scripts/kernel-doc, the latter prints out its help text, causing all
files to be considered containing kerneldoc.
Get rid of these false positives by removing the no longer supported
"-text" option from the scripts/kernel-doc invocation.
Cc: stable@vger.kernel.org # 4.16+
Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200127093107.26401-1-geert+renesas@glider.be
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/find-unused-docs.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/find-unused-docs.sh b/scripts/find-unused-docs.sh index 3f46f8977dc4..ee6a50e33aba 100755 --- a/scripts/find-unused-docs.sh +++ b/scripts/find-unused-docs.sh @@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do if [[ ${FILES_INCLUDED[$file]+_} ]]; then continue; fi - str=$(scripts/kernel-doc -text -export "$file" 2>/dev/null) + str=$(scripts/kernel-doc -export "$file" 2>/dev/null) if [[ -n "$str" ]]; then echo "$file" fi |