diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2024-05-05 03:33:33 +0900 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2024-05-10 04:34:53 +0900 |
| commit | 8a22f867e330965539b9cb5ccc42c2b470330b43 (patch) | |
| tree | 5eb7ecf715b7b119066802e955391ecc79c35c6b /scripts/kconfig/menu.c | |
| parent | 700e7a8d05ea690308131f69ffc597dfab6db838 (diff) | |
| download | lwn-8a22f867e330965539b9cb5ccc42c2b470330b43.tar.gz lwn-8a22f867e330965539b9cb5ccc42c2b470330b43.zip | |
kconfig: turn defaults and additional prompt for choice members into error
menu_finalize() warns default properties for choice members and prompts
outside the choice block. These should be hard errors.
While I was here, I moved the checks to slim down menu_finalize().
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/kconfig/menu.c')
| -rw-r--r-- | scripts/kconfig/menu.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index a9b1e451dfe7..bee96c9964fd 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -507,16 +507,6 @@ static void _menu_finalize(struct menu *parent, bool inside_choice) menu->sym && !sym_is_choice_value(menu->sym)) { current_entry = menu; menu->sym->flags |= SYMBOL_CHOICEVAL; - for (prop = menu->sym->prop; prop; prop = prop->next) { - if (prop->type == P_DEFAULT) - prop_warn(prop, "defaults for choice " - "values not supported"); - if (prop->menu == menu) - continue; - if (prop->type == P_PROMPT && - prop->menu->parent->sym != sym) - prop_warn(prop, "choice value used outside its choice group"); - } /* Non-tristate choice values of tristate choices must * depend on the choice being set to Y. The choice * values' dependencies were propagated to their |