diff options
| author | Zhao Hongjiang <zhaohongjiang@huawei.com> | 2013-06-20 19:05:40 +0800 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-07-01 07:13:33 -0400 |
| commit | d8fae2f64433cbe7f0389f965081348272b61ff9 (patch) | |
| tree | 96876cac1d8b42772d6135e199fc6e88acb36bcb /samples/trace_events | |
| parent | 9674b2fadab636b1fe27b282f9a9fa0f9d8c9839 (diff) | |
| download | lwn-d8fae2f64433cbe7f0389f965081348272b61ff9.tar.gz lwn-d8fae2f64433cbe7f0389f965081348272b61ff9.zip | |
tracing: Change trace event sample to use strlcpy instead of strncpy
Strings should be copied with strlcpy instead of strncpy when they will
later be printed via %s. This guarantees that they terminate with a
NUL '\0' character and do not run pass the end of the allocated string.
This is only for sample code, but it should stil represent a good
role model.
Link: http://lkml.kernel.org/p/51C2E204.1080501@huawei.com
Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'samples/trace_events')
| -rw-r--r-- | samples/trace_events/trace-events-sample.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h index 4b0113f73ee9..476429281389 100644 --- a/samples/trace_events/trace-events-sample.h +++ b/samples/trace_events/trace-events-sample.h @@ -87,7 +87,7 @@ TRACE_EVENT(foo_bar, ), TP_fast_assign( - strncpy(__entry->foo, foo, 10); + strlcpy(__entry->foo, foo, 10); __entry->bar = bar; ), |