diff options
| author | David Laight <David.Laight@ACULAB.COM> | 2020-08-19 14:40:52 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-20 16:37:37 -0700 |
| commit | ab921f3cdbec01c68705a7ade8bec628d541fc2b (patch) | |
| tree | 2a75fcdc873fe7920d049de83c7a372ab389f45e /net | |
| parent | 41506bff84f1563e20e505ca9a0366a30ae2a879 (diff) | |
| download | lwn-ab921f3cdbec01c68705a7ade8bec628d541fc2b.tar.gz lwn-ab921f3cdbec01c68705a7ade8bec628d541fc2b.zip | |
net: sctp: Fix negotiation of the number of data streams.
The number of output and input streams was never being reduced, eg when
processing received INIT or INIT_ACK chunks.
The effect is that DATA chunks can be sent with invalid stream ids
and then discarded by the remote system.
Fixes: 2075e50caf5ea ("sctp: convert to genradix")
Signed-off-by: David Laight <david.laight@aculab.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/stream.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/sctp/stream.c b/net/sctp/stream.c index bda2536dd740..6dc95dcc0ff4 100644 --- a/net/sctp/stream.c +++ b/net/sctp/stream.c @@ -88,12 +88,13 @@ static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt, int ret; if (outcnt <= stream->outcnt) - return 0; + goto out; ret = genradix_prealloc(&stream->out, outcnt, gfp); if (ret) return ret; +out: stream->outcnt = outcnt; return 0; } @@ -104,12 +105,13 @@ static int sctp_stream_alloc_in(struct sctp_stream *stream, __u16 incnt, int ret; if (incnt <= stream->incnt) - return 0; + goto out; ret = genradix_prealloc(&stream->in, incnt, gfp); if (ret) return ret; +out: stream->incnt = incnt; return 0; } |