diff options
| author | Xin Long <lucien.xin@gmail.com> | 2022-11-16 15:01:18 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-11-18 11:42:54 +0000 |
| commit | f87b1ac06c887210782eab9f105ffd9045be74cc (patch) | |
| tree | c78801562f90f7e6d9c91db8929471a0901fb1ea /net/sctp | |
| parent | 6fe1e52490a91cb23f6b3aafc93e7c5beb99f862 (diff) | |
| download | lwn-f87b1ac06c887210782eab9f105ffd9045be74cc.tar.gz lwn-f87b1ac06c887210782eab9f105ffd9045be74cc.zip | |
sctp: check sk_bound_dev_if when matching ep in get_port
In sctp_get_port_local(), when binding to IP and PORT, it should
also check sk_bound_dev_if to match listening sk if it's set by
SO_BINDTOIFINDEX, so that multiple sockets with the same IP and
PORT, but different sk_bound_dev_if can be listened at the same
time.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/socket.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 3e83963d1b8a..4306164238ef 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -8398,6 +8398,7 @@ pp_found: * in an endpoint. */ sk_for_each_bound(sk2, &pp->owner) { + int bound_dev_if2 = READ_ONCE(sk2->sk_bound_dev_if); struct sctp_sock *sp2 = sctp_sk(sk2); struct sctp_endpoint *ep2 = sp2->ep; @@ -8408,7 +8409,9 @@ pp_found: uid_eq(uid, sock_i_uid(sk2)))) continue; - if (sctp_bind_addr_conflict(&ep2->base.bind_addr, + if ((!sk->sk_bound_dev_if || !bound_dev_if2 || + sk->sk_bound_dev_if == bound_dev_if2) && + sctp_bind_addr_conflict(&ep2->base.bind_addr, addr, sp2, sp)) { ret = 1; goto fail_unlock; |