diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2021-03-08 01:13:55 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-08 15:02:53 -0800 |
| commit | 179d0ba0c454057a65929c46af0d6ad986754781 (patch) | |
| tree | 1c98c5e29f458d1849ac09e78c1cd927dab3e61d /net/qrtr | |
| parent | 27ab92d9996e4e003a726d22c56d780a1655d6b4 (diff) | |
| download | lwn-179d0ba0c454057a65929c46af0d6ad986754781.tar.gz lwn-179d0ba0c454057a65929c46af0d6ad986754781.zip | |
net: qrtr: fix error return code of qrtr_sendmsg()
When sock_alloc_send_skb() returns NULL to skb, no error return code of
qrtr_sendmsg() is assigned.
To fix this bug, rc is assigned with -ENOMEM in this case.
Fixes: 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/qrtr')
| -rw-r--r-- | net/qrtr/qrtr.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 82d2eb8c21d1..edb6ac17ceca 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -958,8 +958,10 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) plen = (len + 3) & ~3; skb = sock_alloc_send_skb(sk, plen + QRTR_HDR_MAX_SIZE, msg->msg_flags & MSG_DONTWAIT, &rc); - if (!skb) + if (!skb) { + rc = -ENOMEM; goto out_node; + } skb_reserve(skb, QRTR_HDR_MAX_SIZE); |