diff options
| author | Li Zetao <lizetao1@huawei.com> | 2024-08-22 12:32:48 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-08-23 14:27:45 +0100 |
| commit | ebe39f95bc8138eedaba9adaa5a4d7bfe98a9806 (patch) | |
| tree | 6abefcff5f61ada033b6981906be588689fcc469 /net/ipv4 | |
| parent | 4c180887775f3e3fb46b9e447cf3ea539286919d (diff) | |
| download | lwn-ebe39f95bc8138eedaba9adaa5a4d7bfe98a9806.tar.gz lwn-ebe39f95bc8138eedaba9adaa5a4d7bfe98a9806.zip | |
ipmr: delete redundant judgment statements
The initial value of err is -ENOBUFS, and err is guaranteed to be
less than 0 before all goto errout. Therefore, on the error path
of errout, there is no need to repeatedly judge that err is less than 0,
and delete redundant judgments to make the code more concise.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/ipmr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index d5295b69bc0a..b0eda745e3bc 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -2407,8 +2407,7 @@ static void mroute_netlink_event(struct mr_table *mrt, struct mfc_cache *mfc, errout: kfree_skb(skb); - if (err < 0) - rtnl_set_sk_err(net, RTNLGRP_IPV4_MROUTE, err); + rtnl_set_sk_err(net, RTNLGRP_IPV4_MROUTE, err); } static size_t igmpmsg_netlink_msgsize(size_t payloadlen) |