diff options
| author | Sven Eckelmann <sven@narfation.org> | 2022-08-20 09:32:50 +0200 |
|---|---|---|
| committer | Simon Wunderlich <sw@simonwunderlich.de> | 2022-08-20 09:40:51 +0200 |
| commit | 813e62a6fe7539fdf0d8e018d4f157b57bdaeedd (patch) | |
| tree | 293e3c6969a27bbfc30fd443a6897dea7ac3b59c /net/batman-adv | |
| parent | 7d315c07eda7ae1bf54f2a05291504b006aecab5 (diff) | |
| download | lwn-813e62a6fe7539fdf0d8e018d4f157b57bdaeedd.tar.gz lwn-813e62a6fe7539fdf0d8e018d4f157b57bdaeedd.zip | |
batman-adv: Drop initialization of flexible ethtool_link_ksettings
The commit 94dfc73e7cf4 ("treewide: uapi: Replace zero-length arrays with
flexible-array members") changed various structures from using 0-length
arrays to flexible arrays
net/batman-adv/bat_v_elp.c: note: in included file:
./include/linux/ethtool.h:148:38: warning: nested flexible array
net/batman-adv/bat_v_elp.c:128:9: warning: using sizeof on a flexible structure
In theory, this could be worked around by using {} as initializer for the
variable on the stack. But this variable doesn't has to be initialized at
all by the caller of __ethtool_get_link_ksettings - everything will be
initialized by the callee when no error occurs.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv')
| -rw-r--r-- | net/batman-adv/bat_v_elp.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c index b6db999abf75..f1741fbfb617 100644 --- a/net/batman-adv/bat_v_elp.c +++ b/net/batman-adv/bat_v_elp.c @@ -125,7 +125,6 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) /* if not a wifi interface, check if this device provides data via * ethtool (e.g. an Ethernet adapter) */ - memset(&link_settings, 0, sizeof(link_settings)); rtnl_lock(); ret = __ethtool_get_link_ksettings(hard_iface->net_dev, &link_settings); rtnl_unlock(); |