diff options
author | Alice Ryhl <aliceryhl@google.com> | 2023-06-14 11:53:28 +0000 |
---|---|---|
committer | Miguel Ojeda <ojeda@kernel.org> | 2023-08-10 01:18:34 +0200 |
commit | 35cad617df2eeef8440a38e82bb2d81ae32ca50d (patch) | |
tree | c242223c7b6afcd9846da86b59d6eeccfefbcda7 /lib/syscall.c | |
parent | 0bb1c9282e2cb38d199347d1d96b77f208b64810 (diff) | |
download | lwn-35cad617df2eeef8440a38e82bb2d81ae32ca50d.tar.gz lwn-35cad617df2eeef8440a38e82bb2d81ae32ca50d.zip |
rust: make `UnsafeCell` the outer type in `Opaque`
When combining `UnsafeCell` with `MaybeUninit`, it is idiomatic to use
`UnsafeCell` as the outer type. Intuitively, this is because a
`MaybeUninit<T>` might not contain a `T`, but we always want the effect
of the `UnsafeCell`, even if the inner value is uninitialized.
Now, strictly speaking, this doesn't really make a difference. The
compiler will always apply the `UnsafeCell` effect even if the inner
value is uninitialized. But I think we should follow the convention
here.
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Link: https://lore.kernel.org/r/20230614115328.2825961-1-aliceryhl@google.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'lib/syscall.c')
0 files changed, 0 insertions, 0 deletions