diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2018-07-13 21:50:01 -0700 |
|---|---|---|
| committer | Dave Jiang <dave.jiang@intel.com> | 2018-07-23 10:37:39 -0700 |
| commit | 2fa147bdbf672c53386a8f5f2c7fe358004c3ef8 (patch) | |
| tree | 7cf0718fabe780c0faf9337a6f8262826cb1dc37 /kernel/memremap.c | |
| parent | 86a66810baa87e5d1c93a51f71d36c7f71fe3113 (diff) | |
| download | lwn-2fa147bdbf672c53386a8f5f2c7fe358004c3ef8.tar.gz lwn-2fa147bdbf672c53386a8f5f2c7fe358004c3ef8.zip | |
mm, dev_pagemap: Do not clear ->mapping on final put
MEMORY_DEVICE_FS_DAX relies on typical page semantics whereby ->mapping
is only ever cleared by truncation, not final put.
Without this fix dax pages may forget their mapping association at the
end of every page pin event.
Move this atypical behavior that HMM wants into the HMM ->page_free()
callback.
Cc: <stable@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Fixes: d2c997c0f145 ("fs, dax: use page->mapping...")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'kernel/memremap.c')
| -rw-r--r-- | kernel/memremap.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/memremap.c b/kernel/memremap.c index 5857267a4af5..62603634a1d2 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -339,7 +339,6 @@ void __put_devmap_managed_page(struct page *page) __ClearPageActive(page); __ClearPageWaiters(page); - page->mapping = NULL; mem_cgroup_uncharge(page); page->pgmap->page_free(page, page->pgmap->data); |