diff options
| author | Matteo Croce <teknoraver@meta.com> | 2024-10-10 04:56:52 +0100 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2024-10-10 08:52:36 -0700 |
| commit | 5bd48a3a14df4b3ee1be0757efcc0f40d4f57b35 (patch) | |
| tree | 65e2ea6fdecffdfec494ec9b8ee4cd985d136d42 /kernel/bpf | |
| parent | 4073213488be542f563eb4b2457ab4cbcfc2b738 (diff) | |
| download | lwn-5bd48a3a14df4b3ee1be0757efcc0f40d4f57b35.tar.gz lwn-5bd48a3a14df4b3ee1be0757efcc0f40d4f57b35.zip | |
bpf: fix argument type in bpf_loop documentation
The `index` argument to bpf_loop() is threaded as an u64.
This lead in a subtle verifier denial where clang cloned the argument
in another register[1].
[1] https://github.com/systemd/systemd/pull/34650#issuecomment-2401092895
Signed-off-by: Matteo Croce <teknoraver@meta.com>
Link: https://lore.kernel.org/r/20241010035652.17830-1-technoboy85@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/bpf')
| -rw-r--r-- | kernel/bpf/verifier.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 7d9b38ffd220..cfc62e0776bf 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9917,7 +9917,7 @@ static int set_loop_callback_state(struct bpf_verifier_env *env, { /* bpf_loop(u32 nr_loops, void *callback_fn, void *callback_ctx, * u64 flags); - * callback_fn(u32 index, void *callback_ctx); + * callback_fn(u64 index, void *callback_ctx); */ callee->regs[BPF_REG_1].type = SCALAR_VALUE; callee->regs[BPF_REG_2] = caller->regs[BPF_REG_3]; |