diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2022-12-29 17:33:33 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-01-01 09:27:12 +0000 |
| commit | d9dba91be71f03cc75bcf39fc0d5d99ff33f1ae0 (patch) | |
| tree | 066b828aa57522066a844b87f3ff0746e9a177cc /include | |
| parent | 9807ae69746196ee4bbffe7d22d22ab2b61c6ed0 (diff) | |
| download | lwn-d9dba91be71f03cc75bcf39fc0d5d99ff33f1ae0.tar.gz lwn-d9dba91be71f03cc75bcf39fc0d5d99ff33f1ae0.zip | |
net: dsa: tag_qca: fix wrong MGMT_DATA2 size
It was discovered that MGMT_DATA2 can contain up to 28 bytes of data
instead of the 12 bytes written in the Documentation by accounting the
limit of 16 bytes declared in Documentation subtracting the first 4 byte
in the packet header.
Update the define with the real world value.
Tested-by: Ronald Wahl <ronald.wahl@raritan.com>
Fixes: c2ee8181fddb ("net: dsa: tag_qca: add define for handling mgmt Ethernet packet")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org # v5.18+
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/dsa/tag_qca.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/dsa/tag_qca.h b/include/linux/dsa/tag_qca.h index b1b5720d89a5..ee657452f122 100644 --- a/include/linux/dsa/tag_qca.h +++ b/include/linux/dsa/tag_qca.h @@ -45,8 +45,8 @@ struct sk_buff; QCA_HDR_MGMT_COMMAND_LEN + \ QCA_HDR_MGMT_DATA1_LEN) -#define QCA_HDR_MGMT_DATA2_LEN 12 /* Other 12 byte for the mdio data */ -#define QCA_HDR_MGMT_PADDING_LEN 34 /* Padding to reach the min Ethernet packet */ +#define QCA_HDR_MGMT_DATA2_LEN 28 /* Other 28 byte for the mdio data */ +#define QCA_HDR_MGMT_PADDING_LEN 18 /* Padding to reach the min Ethernet packet */ #define QCA_HDR_MGMT_PKT_LEN (QCA_HDR_MGMT_HEADER_LEN + \ QCA_HDR_LEN + \ |