diff options
| author | Takashi Iwai <tiwai@suse.de> | 2022-07-28 14:59:45 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2022-07-29 12:57:12 +0200 |
| commit | 4a971e84a7ae10a38d875cd2d4e487c8d1682ca3 (patch) | |
| tree | 750576e84d71b0f772fdb1c267e340ede1377de4 /include/sound | |
| parent | 96b097091c66df4f6fbf5cbff21df6cc02a2f055 (diff) | |
| download | lwn-4a971e84a7ae10a38d875cd2d4e487c8d1682ca3.tar.gz lwn-4a971e84a7ae10a38d875cd2d4e487c8d1682ca3.zip | |
ALSA: control: Use deferred fasync helper
For avoiding the potential deadlock via kill_fasync() call, use the
new fasync helpers to defer the invocation from the control API. Note
that it's merely a workaround.
Another note: although we haven't received reports about the deadlock
with the control API, the deadlock is still potentially possible, and
it's better to align the behavior with other core APIs (PCM and
timer); so let's move altogether.
Link: https://lore.kernel.org/r/20220728125945.29533-5-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound')
| -rw-r--r-- | include/sound/control.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/sound/control.h b/include/sound/control.h index fcd3cce673ec..eae443ba79ba 100644 --- a/include/sound/control.h +++ b/include/sound/control.h @@ -109,7 +109,7 @@ struct snd_ctl_file { int preferred_subdevice[SND_CTL_SUBDEV_ITEMS]; wait_queue_head_t change_sleep; spinlock_t read_lock; - struct fasync_struct *fasync; + struct snd_fasync *fasync; int subscribed; /* read interface is activated */ struct list_head events; /* waiting events for read */ }; |