diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2022-08-21 15:05:02 -0700 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-09-01 01:02:10 -0400 |
| commit | f782201ebc2b5f6c7a22e586e8eb81fe1d9e4801 (patch) | |
| tree | f76d4ca8cdc0bf5816cb135df358164b0e909519 /include/scsi | |
| parent | d94b2d00f7bfa0c555e7b8724b1faa037d57d150 (diff) | |
| download | lwn-f782201ebc2b5f6c7a22e586e8eb81fe1d9e4801.tar.gz lwn-f782201ebc2b5f6c7a22e586e8eb81fe1d9e4801.zip | |
scsi: core: Revert "Make sure that targets outlive devices"
Revert the patch series "Call blk_mq_free_tag_set() earlier" because it
introduces a deadlock if the scsi_remove_host() caller holds a reference on
a device, target or host.
Link: https://lore.kernel.org/r/20220821220502.13685-5-bvanassche@acm.org
Fixes: fe442604199e ("scsi: core: Make sure that targets outlive devices")
Reported-by: syzbot+bafeb834708b1bb750bc@syzkaller.appspotmail.com
Tested-by: Kenneth R. Crudup <kenny@panix.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/scsi')
| -rw-r--r-- | include/scsi/scsi_device.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 3113471ca375..2493bd65351a 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -309,8 +309,6 @@ struct scsi_target { struct list_head devices; struct device dev; struct kref reap_ref; /* last put renders target invisible */ - atomic_t sdev_count; - wait_queue_head_t sdev_wq; unsigned int channel; unsigned int id; /* target id ... replace * scsi_device.id eventually */ |