diff options
author | Jalal Mostafa <jalal.a.mostapha@gmail.com> | 2022-09-21 13:57:01 +0000 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2022-09-22 17:16:22 +0200 |
commit | 60240bc26114543fcbfcd8a28466e67e77b20388 (patch) | |
tree | 0d5a7fd46fb68f10361fb39e1757989d6f5347d7 /include/net | |
parent | 8addbfc7b308d591f8a5f2f6bb24d08d9d79dfbb (diff) | |
download | lwn-60240bc26114543fcbfcd8a28466e67e77b20388.tar.gz lwn-60240bc26114543fcbfcd8a28466e67e77b20388.zip |
xsk: Inherit need_wakeup flag for shared sockets
The flag for need_wakeup is not set for xsks with `XDP_SHARED_UMEM`
flag and of different queue ids and/or devices. They should inherit
the flag from the first socket buffer pool since no flags can be
specified once `XDP_SHARED_UMEM` is specified.
Fixes: b5aea28dca134 ("xsk: Add shared umem support between queue ids")
Signed-off-by: Jalal Mostafa <jalal.a.mostapha@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20220921135701.10199-1-jalal.a.mostapha@gmail.com
Diffstat (limited to 'include/net')
-rw-r--r-- | include/net/xsk_buff_pool.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/xsk_buff_pool.h b/include/net/xsk_buff_pool.h index 647722e847b4..f787c3f524b0 100644 --- a/include/net/xsk_buff_pool.h +++ b/include/net/xsk_buff_pool.h @@ -95,7 +95,7 @@ struct xsk_buff_pool *xp_create_and_assign_umem(struct xdp_sock *xs, struct xdp_umem *umem); int xp_assign_dev(struct xsk_buff_pool *pool, struct net_device *dev, u16 queue_id, u16 flags); -int xp_assign_dev_shared(struct xsk_buff_pool *pool, struct xdp_umem *umem, +int xp_assign_dev_shared(struct xsk_buff_pool *pool, struct xdp_sock *umem_xs, struct net_device *dev, u16 queue_id); int xp_alloc_tx_descs(struct xsk_buff_pool *pool, struct xdp_sock *xs); void xp_destroy(struct xsk_buff_pool *pool); |