diff options
| author | David Ahern <dsahern@gmail.com> | 2017-12-03 09:33:00 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-12-03 12:39:15 -0500 |
| commit | b4d1605a8ea608fd7dc45b926a05d75d340bde4b (patch) | |
| tree | 738365d5e9a0912dc35421e5ce357b6e0e4422c8 /include/net/tcp.h | |
| parent | eeea10b83a139451130df1594f26710c8fa390c8 (diff) | |
| download | lwn-b4d1605a8ea608fd7dc45b926a05d75d340bde4b.tar.gz lwn-b4d1605a8ea608fd7dc45b926a05d75d340bde4b.zip | |
tcp: use IPCB instead of TCP_SKB_CB in inet_exact_dif_match()
After this fix : ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()"),
socket lookups happen while skb->cb[] has not been mangled yet by TCP.
Fixes: a04a480d4392 ("net: Require exact match for TCP socket lookups if dif is l3mdev")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/tcp.h')
| -rw-r--r-- | include/net/tcp.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/net/tcp.h b/include/net/tcp.h index 4e09398009c1..6998707e81f3 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -844,12 +844,11 @@ static inline int tcp_v6_sdif(const struct sk_buff *skb) } #endif -/* TCP_SKB_CB reference means this can not be used from early demux */ static inline bool inet_exact_dif_match(struct net *net, struct sk_buff *skb) { #if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) if (!net->ipv4.sysctl_tcp_l3mdev_accept && - skb && ipv4_l3mdev_skb(TCP_SKB_CB(skb)->header.h4.flags)) + skb && ipv4_l3mdev_skb(IPCB(skb)->flags)) return true; #endif return false; |