diff options
author | Nuno Sa <nuno.sa@analog.com> | 2024-10-01 07:46:44 -0700 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2024-10-01 07:48:48 -0700 |
commit | fb5cc65f973661241e4a2b7390b429aa7b330c69 (patch) | |
tree | 0b829981a3cdf48bdece0c409720434d53e3ef79 /include/net/smc.h | |
parent | a3f9a74d210bf5b80046a840d3e9949b5fe0a67c (diff) | |
download | lwn-fb5cc65f973661241e4a2b7390b429aa7b330c69.tar.gz lwn-fb5cc65f973661241e4a2b7390b429aa7b330c69.zip |
Input: adp5589-keys - fix NULL pointer dereference
We register a devm action to call adp5589_clear_config() and then pass
the i2c client as argument so that we can call i2c_get_clientdata() in
order to get our device object. However, i2c_set_clientdata() is only
being set at the end of the probe function which means that we'll get a
NULL pointer dereference in case the probe function fails early.
Fixes: 30df385e35a4 ("Input: adp5589-keys - use devm_add_action_or_reset() for register clear")
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20241001-b4-dev-adp5589-fw-conversion-v1-1-fca0149dfc47@analog.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'include/net/smc.h')
0 files changed, 0 insertions, 0 deletions