diff options
| author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2022-10-17 10:04:32 +0300 |
|---|---|---|
| committer | Sakari Ailus <sakari.ailus@linux.intel.com> | 2022-10-27 14:38:03 +0300 |
| commit | 379c258677ccf0dab1032d531829f6d8440713fa (patch) | |
| tree | c63d444c884ff20405c43965bae785df0d337884 /include/media | |
| parent | 5f9a089b6de34655318afe8e544d9a9cc0fc1d29 (diff) | |
| download | lwn-379c258677ccf0dab1032d531829f6d8440713fa.tar.gz lwn-379c258677ccf0dab1032d531829f6d8440713fa.zip | |
v4l: subdev: Warn if disabling streaming failed, return success
Complain in the newly added s_stream video op wrapper if disabling
streaming failed. Also return zero in this case as there's nothing the
caller can do to return the error.
This way drivers also won't need to bother with printing error messages.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Diffstat (limited to 'include/media')
| -rw-r--r-- | include/media/v4l2-subdev.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 54566d139da7..b15fa9930f30 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -440,8 +440,10 @@ enum v4l2_subdev_pre_streamon_flags { * @g_input_status: get input status. Same as the status field in the * &struct v4l2_input * - * @s_stream: used to notify the driver that a video stream will start or has - * stopped. + * @s_stream: start (enabled == 1) or stop (enabled == 0) streaming on the + * sub-device. Failure on stop will remove any resources acquired in + * streaming start, while the error code is still returned by the driver. + * Also see call_s_stream wrapper in v4l2-subdev.c. * * @g_pixelaspect: callback to return the pixelaspect ratio. * |