diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-06-04 17:29:01 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-06-09 10:13:04 -0700 |
| commit | 8845484367dade6811bbc3c0c1d66a2a0721c3c0 (patch) | |
| tree | cdb0a0a977a42912a31c87250e11d512b659eb9b /include/linux | |
| parent | 9415471e01c1aaac43daa6af3a261dc0c6c3a47c (diff) | |
| download | lwn-8845484367dade6811bbc3c0c1d66a2a0721c3c0.tar.gz lwn-8845484367dade6811bbc3c0c1d66a2a0721c3c0.zip | |
net: ethtool: serialize broadcast notification sequence allocation
ethnl_bcast_seq is a global counter stamped into the nlmsg_seq field
of every multicast notification, allowing userspace to detect dropped
messages. Today the ordering is achieved by using rtnl_lock().
Moving forward we will want ethtool ops to run under just the netdev
instance lock so to establish ordering we need a separate lock
for notifications. With the netdev instance locks operations on
different devices may bypass each other but the expectation is
that it should not matter. What we need to prevent is:
- notification IDs getting out of order
- operations on one device getting out of order
For simplicity defer allocating the ID of the notification right
before the notification is delivered. This removes the need for
special handling in ethnl_rss_create_send_ntf().
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260605002912.3456868-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions
