diff options
| author | Ross Lagerwall <ross.lagerwall@citrix.com> | 2019-01-17 15:34:38 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-18 14:05:14 -0800 |
| commit | 6c57f0458022298e4da1729c67bd33ce41c14e7a (patch) | |
| tree | c56bc8518423b39cabbda138327a313262ea1e9e /include/linux/skbuff.h | |
| parent | e40e2a2e78664fa90ea4b9bdf4a84efce2fea9d9 (diff) | |
| download | lwn-6c57f0458022298e4da1729c67bd33ce41c14e7a.tar.gz lwn-6c57f0458022298e4da1729c67bd33ce41c14e7a.zip | |
net: Fix usage of pskb_trim_rcsum
In certain cases, pskb_trim_rcsum() may change skb pointers.
Reinitialize header pointers afterwards to avoid potential
use-after-frees. Add a note in the documentation of
pskb_trim_rcsum(). Found by KASAN.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/skbuff.h')
| -rw-r--r-- | include/linux/skbuff.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 93f56fddd92a..95d25b010a25 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3218,6 +3218,7 @@ int pskb_trim_rcsum_slow(struct sk_buff *skb, unsigned int len); * * This is exactly the same as pskb_trim except that it ensures the * checksum of received packets are still valid after the operation. + * It can change skb pointers. */ static inline int pskb_trim_rcsum(struct sk_buff *skb, unsigned int len) |