diff options
| author | Paulo Alcantara <pc@cjr.nz> | 2022-12-19 10:21:50 -0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-12-19 08:04:41 -0600 |
| commit | f60ffa662d1427cfd31fe9d895c3566ac50bfe52 (patch) | |
| tree | 01f9985cb8d4934c809c18c7a1dbe23594aa7157 /fs | |
| parent | 7ad54b98fc1f141cfb70cfe2a3d6def5a85169ff (diff) | |
| download | lwn-f60ffa662d1427cfd31fe9d895c3566ac50bfe52.tar.gz lwn-f60ffa662d1427cfd31fe9d895c3566ac50bfe52.zip | |
cifs: don't leak -ENOMEM in smb2_open_file()
A NULL error response might be a valid case where smb2_reconnect()
failed to reconnect the session and tcon due to a disconnected server
prior to issuing the I/O operation, so don't leak -ENOMEM to userspace
on such occasions.
Fixes: 76894f3e2f71 ("cifs: improve symlink handling for smb2+")
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/smb2file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cifs/smb2file.c b/fs/cifs/smb2file.c index ffbd9a99fc12..ba6cc50af390 100644 --- a/fs/cifs/smb2file.c +++ b/fs/cifs/smb2file.c @@ -122,8 +122,8 @@ int smb2_open_file(const unsigned int xid, struct cifs_open_parms *oparms, __u32 struct smb2_hdr *hdr = err_iov.iov_base; if (unlikely(!err_iov.iov_base || err_buftype == CIFS_NO_BUFFER)) - rc = -ENOMEM; - else if (hdr->Status == STATUS_STOPPED_ON_SYMLINK) { + goto out; + if (hdr->Status == STATUS_STOPPED_ON_SYMLINK) { rc = smb2_parse_symlink_response(oparms->cifs_sb, &err_iov, &data->symlink_target); if (!rc) { |