diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-08-29 22:22:35 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-08-29 20:28:37 -0500 |
| commit | 844436e045ac2ab7895d8b281cb784a24de1d14d (patch) | |
| tree | 437a14dc2f5bf5e05b9ea631bd3371185091f393 /fs | |
| parent | 78c5a6f1f630172b19af4912e755e1da93ef0ab5 (diff) | |
| download | lwn-844436e045ac2ab7895d8b281cb784a24de1d14d.tar.gz lwn-844436e045ac2ab7895d8b281cb784a24de1d14d.zip | |
ksmbd: Unlock on in ksmbd_tcp_set_interfaces()
Unlock before returning an error code if this allocation fails.
Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/transport_tcp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c index a84788396daa..aaed9e293b2e 100644 --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -624,8 +624,10 @@ int ksmbd_tcp_set_interfaces(char *ifc_list, int ifc_list_sz) for_each_netdev(&init_net, netdev) { if (netif_is_bridge_port(netdev)) continue; - if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) + if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) { + rtnl_unlock(); return -ENOMEM; + } } rtnl_unlock(); bind_additional_ifaces = 1; |