diff options
| author | Sargun Dhillon <sargun@sargun.me> | 2017-09-17 09:02:29 +0000 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-09-26 14:54:01 +0200 |
| commit | 36b96fdc6b2dc6f4a0fedc563fa7508c91b90a10 (patch) | |
| tree | f570c3e39fcb38ef16de37bb8847db98611c45ec /fs | |
| parent | e6311f240c946788131ba2b97e14f37312688072 (diff) | |
| download | lwn-36b96fdc6b2dc6f4a0fedc563fa7508c91b90a10.tar.gz lwn-36b96fdc6b2dc6f4a0fedc563fa7508c91b90a10.zip | |
btrfs: Report error on removing qgroup if del_qgroup_item fails
Previously, we were calling del_qgroup_item, and ignoring the return code
resulting in a potential to have divergent in-memory state without an
error. Perhaps, it makes sense to handle this error code, and put the
filesystem into a read only, or similar state.
This patch only adds reporting of the error if the error is fatal,
(any error other than qgroup not found).
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
Reviewed-by: Qu Wenruo <quwenruo.btrfs@gmx.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/qgroup.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 770f667269f5..e172d4843eae 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -1305,6 +1305,8 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, } } ret = del_qgroup_item(trans, quota_root, qgroupid); + if (ret && ret != -ENOENT) + goto out; while (!list_empty(&qgroup->groups)) { list = list_first_entry(&qgroup->groups, |