diff options
| author | Brian Foster <bfoster@redhat.com> | 2012-12-21 10:45:17 -0500 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2013-01-03 15:58:39 -0600 |
| commit | f755503206ef705c20db622637d80a3e1b94a6f5 (patch) | |
| tree | 8945164d2a310dc65730ca22e5dbdf8e9c8c3fd9 /fs/xfs | |
| parent | 56431cd194ca67a899a2a01a90ee94388ade1d0b (diff) | |
| download | lwn-f755503206ef705c20db622637d80a3e1b94a6f5.tar.gz lwn-f755503206ef705c20db622637d80a3e1b94a6f5.zip | |
xfs: remove int casts from debug dquot soft limit timer asserts
The int casts here make it easy to trigger an assert with a large
soft limit. For example, set a >4TB soft limit on an empty volume
to reproduce a (0 > -x) comparison due to an overflow of
d_blk_softlimit.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_qm_syscalls.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c index 5f53e75409b8..8a59f8546552 100644 --- a/fs/xfs/xfs_qm_syscalls.c +++ b/fs/xfs/xfs_qm_syscalls.c @@ -784,11 +784,11 @@ xfs_qm_scall_getquota( (XFS_IS_OQUOTA_ENFORCED(mp) && (dst->d_flags & (FS_PROJ_QUOTA | FS_GROUP_QUOTA)))) && dst->d_id != 0) { - if (((int) dst->d_bcount > (int) dst->d_blk_softlimit) && + if ((dst->d_bcount > dst->d_blk_softlimit) && (dst->d_blk_softlimit > 0)) { ASSERT(dst->d_btimer != 0); } - if (((int) dst->d_icount > (int) dst->d_ino_softlimit) && + if ((dst->d_icount > dst->d_ino_softlimit) && (dst->d_ino_softlimit > 0)) { ASSERT(dst->d_itimer != 0); } |