diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-14 06:34:31 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-15 17:57:05 -0700 |
| commit | 689e11c84b15866619e7582486acacaf79d7e3e2 (patch) | |
| tree | 9d27a9b8ed45ea0603bd7f7bd205d2d4855d178c /fs/xfs/scrub/agheader.c | |
| parent | 8389f3ffa22a119b37dc7c2217cd2862bb2ed9da (diff) | |
| download | lwn-689e11c84b15866619e7582486acacaf79d7e3e2.tar.gz lwn-689e11c84b15866619e7582486acacaf79d7e3e2.zip | |
xfs: superblock scrub should use short-lived buffers
Secondary superblocks are rarely used, so create a helper to read a
given non-primary AG's superblock and ensure that it won't stick around
hogging memory.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/xfs/scrub/agheader.c')
| -rw-r--r-- | fs/xfs/scrub/agheader.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/xfs/scrub/agheader.c b/fs/xfs/scrub/agheader.c index 08a1f013d92c..831acc0a328f 100644 --- a/fs/xfs/scrub/agheader.c +++ b/fs/xfs/scrub/agheader.c @@ -157,9 +157,7 @@ xfs_scrub_superblock( if (agno == 0) return 0; - error = xfs_trans_read_buf(mp, sc->tp, mp->m_ddev_targp, - XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)), - XFS_FSS_TO_BB(mp, 1), 0, &bp, &xfs_sb_buf_ops); + error = xfs_sb_read_secondary(mp, sc->tp, agno, &bp); /* * The superblock verifier can return several different error codes * if it thinks the superblock doesn't look right. For a mount these |