diff options
| author | Jeff Layton <jlayton@kernel.org> | 2022-11-11 08:11:53 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-12-11 08:33:31 -0600 |
| commit | 7ecbe92696bb7fe32c80b6cf64736a0d157717a9 (patch) | |
| tree | 4a2d3d21669f0540e770bcb1490ea4a83fec227c /fs/ksmbd | |
| parent | 37ba7b005a7a4454046bd8659c7a9c5330552396 (diff) | |
| download | lwn-7ecbe92696bb7fe32c80b6cf64736a0d157717a9.tar.gz lwn-7ecbe92696bb7fe32c80b6cf64736a0d157717a9.zip | |
ksmbd: use F_SETLK when unlocking a file
ksmbd seems to be trying to use a cmd value of 0 when unlocking a file.
That activity requires a type of F_UNLCK with a cmd of F_SETLK. For
local POSIX locking, it doesn't matter much since vfs_lock_file ignores
@cmd, but filesystems that define their own ->lock operation expect to
see it set sanely.
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: David Howells <dhowells@redhat.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/ksmbd')
| -rw-r--r-- | fs/ksmbd/smb2pdu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c index 56d68ddc409c..de8e367095c9 100644 --- a/fs/ksmbd/smb2pdu.c +++ b/fs/ksmbd/smb2pdu.c @@ -6753,7 +6753,7 @@ static int smb2_set_flock_flags(struct file_lock *flock, int flags) case SMB2_LOCKFLAG_UNLOCK: ksmbd_debug(SMB, "received unlock request\n"); flock->fl_type = F_UNLCK; - cmd = 0; + cmd = F_SETLK; break; } @@ -7131,7 +7131,7 @@ out: rlock->fl_start = smb_lock->start; rlock->fl_end = smb_lock->end; - rc = vfs_lock_file(filp, 0, rlock, NULL); + rc = vfs_lock_file(filp, F_SETLK, rlock, NULL); if (rc) pr_err("rollback unlock fail : %d\n", rc); |