diff options
| author | Yonggil Song <yonggil.song@samsung.com> | 2023-03-13 18:48:25 +0900 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2023-03-29 15:17:38 -0700 |
| commit | 6797ebc4ac55e7539391a5155f8a27f614da6bc5 (patch) | |
| tree | ed2f7fdfbce886954a02136807e8e86f34fae274 /fs/f2fs | |
| parent | bf21acf9959a48d90dd32869a0649525eb21be56 (diff) | |
| download | lwn-6797ebc4ac55e7539391a5155f8a27f614da6bc5.tar.gz lwn-6797ebc4ac55e7539391a5155f8a27f614da6bc5.zip | |
f2fs: Fix discard bug on zoned block devices with 2MiB zone size
When using f2fs on a zoned block device with 2MiB zone size, IO errors
occurs because f2fs tries to write data to a zone that has not been reset.
The cause is that f2fs tries to discard multiple zones at once. This is
caused by a condition in f2fs_clear_prefree_segments that does not check
for zoned block devices when setting the discard range. This leads to
invalid reset commands and write pointer mismatches.
This patch fixes the zoned block device with 2MiB zone size to reset one
zone at a time.
Signed-off-by: Yonggil Song <yonggil.song@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
| -rw-r--r-- | fs/f2fs/segment.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index d135046108ef..67cb0805cdfa 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2069,7 +2069,9 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi, (end - 1) <= cpc->trim_end) continue; - if (!f2fs_lfs_mode(sbi) || !__is_large_section(sbi)) { + /* Should cover 2MB zoned device for zone-based reset */ + if (!f2fs_sb_has_blkzoned(sbi) && + (!f2fs_lfs_mode(sbi) || !__is_large_section(sbi))) { f2fs_issue_discard(sbi, START_BLOCK(sbi, start), (end - start) << sbi->log_blocks_per_seg); continue; |