diff options
| author | Yuezhang Mo <Yuezhang.Mo@sony.com> | 2024-09-03 15:01:09 +0800 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2024-09-18 07:40:58 +0900 |
| commit | d2b537b3e533f28e0d97293fe9293161fe8cd137 (patch) | |
| tree | d24c378472eacec1ecad18554e0af2e4115fb10e /fs/exfat | |
| parent | f761fcdd289d07e8547fef7ac76c3760fc7803f2 (diff) | |
| download | lwn-d2b537b3e533f28e0d97293fe9293161fe8cd137.tar.gz lwn-d2b537b3e533f28e0d97293fe9293161fe8cd137.zip | |
exfat: fix memory leak in exfat_load_bitmap()
If the first directory entry in the root directory is not a bitmap
directory entry, 'bh' will not be released and reassigned, which
will cause a memory leak.
Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
Cc: stable@vger.kernel.org
Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Diffstat (limited to 'fs/exfat')
| -rw-r--r-- | fs/exfat/balloc.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/exfat/balloc.c b/fs/exfat/balloc.c index 0356c88252bd..ce9be95c9172 100644 --- a/fs/exfat/balloc.c +++ b/fs/exfat/balloc.c @@ -91,11 +91,8 @@ int exfat_load_bitmap(struct super_block *sb) return -EIO; type = exfat_get_entry_type(ep); - if (type == TYPE_UNUSED) - break; - if (type != TYPE_BITMAP) - continue; - if (ep->dentry.bitmap.flags == 0x0) { + if (type == TYPE_BITMAP && + ep->dentry.bitmap.flags == 0x0) { int err; err = exfat_allocate_bitmap(sb, ep); @@ -103,6 +100,9 @@ int exfat_load_bitmap(struct super_block *sb) return err; } brelse(bh); + + if (type == TYPE_UNUSED) + return -EINVAL; } if (exfat_get_next_cluster(sb, &clu.dir)) |