diff options
| author | Paulo Alcantara <pc@manguebit.com> | 2023-03-24 16:05:19 -0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-03-24 14:37:05 -0500 |
| commit | c24bb1a87dc3f2d77d410eaac2c6a295961bf50e (patch) | |
| tree | f5459fce89e0fe496a943304ca611d6720837db3 /fs/cifs | |
| parent | bc962159e8e326af634a506508034a375bf2b858 (diff) | |
| download | lwn-c24bb1a87dc3f2d77d410eaac2c6a295961bf50e.tar.gz lwn-c24bb1a87dc3f2d77d410eaac2c6a295961bf50e.zip | |
cifs: fix missing unload_nls() in smb2_reconnect()
Make sure to unload_nls() @nls_codepage if we no longer need it.
Fixes: bc962159e8e3 ("cifs: avoid race conditions with parallel reconnects")
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Cc: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index a9fb95b7ef82..20af1af34fa5 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -144,7 +144,7 @@ smb2_reconnect(__le16 smb2_command, struct cifs_tcon *tcon, struct TCP_Server_Info *server) { int rc = 0; - struct nls_table *nls_codepage; + struct nls_table *nls_codepage = NULL; struct cifs_ses *ses; /* @@ -220,8 +220,6 @@ again: tcon->ses->chans_need_reconnect, tcon->need_reconnect); - nls_codepage = load_nls_default(); - mutex_lock(&ses->session_mutex); /* * Recheck after acquire mutex. If another thread is negotiating @@ -241,6 +239,8 @@ again: } spin_unlock(&server->srv_lock); + nls_codepage = load_nls_default(); + /* * need to prevent multiple threads trying to simultaneously * reconnect the same SMB session |