diff options
| author | Shirish Pargaonkar <shirishp@us.ibm.com> | 2008-02-12 20:46:26 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2008-02-12 20:46:26 +0000 |
| commit | d9f382eff6fbabcd09dad4558d1797c267e9746e (patch) | |
| tree | d59f564418da4b62355ab2576aee02bee38f3add /fs/cifs/cifsacl.c | |
| parent | 6f7e8f376360c789cf84a0321960dcef8bf92aff (diff) | |
| download | lwn-d9f382eff6fbabcd09dad4558d1797c267e9746e.tar.gz lwn-d9f382eff6fbabcd09dad4558d1797c267e9746e.zip | |
[CIFS] patch to fix incorrect encoding of number of aces on set mode
This patch fixes an error in the experimental cifs acl code. During chmod,
set security descriptor data (num aces) is not sent with little-endian encoding.
Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifsacl.c')
| -rw-r--r-- | fs/cifs/cifsacl.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c index 49485108454f..f93932c21772 100644 --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -372,10 +372,6 @@ static void parse_dacl(struct cifs_acl *pdacl, char *end_of_acl, ppace = kmalloc(num_aces * sizeof(struct cifs_ace *), GFP_KERNEL); -/* cifscred->cecount = pdacl->num_aces; - cifscred->aces = kmalloc(num_aces * - sizeof(struct cifs_ace *), GFP_KERNEL);*/ - for (i = 0; i < num_aces; ++i) { ppace[i] = (struct cifs_ace *) (acl_base + acl_size); #ifdef CONFIG_CIFS_DEBUG2 @@ -428,7 +424,7 @@ static int set_chmod_dacl(struct cifs_acl *pndacl, struct cifs_sid *pownersid, &sid_everyone, nmode, S_IRWXO); pndacl->size = cpu_to_le16(size + sizeof(struct cifs_acl)); - pndacl->num_aces = 3; + pndacl->num_aces = cpu_to_le32(3); return (0); } |