diff options
| author | David Hildenbrand <david@redhat.com> | 2022-09-23 13:34:25 +0200 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2022-09-29 13:20:53 -0600 |
| commit | 69d517e6e21099f81efbd39e47874649ae575804 (patch) | |
| tree | 86d52da45f0ef03171422a8fe18cbe5466642d74 /fs/attr.c | |
| parent | 1cfd9d7e43d5a1cf739d1420b10b1e65feb02f88 (diff) | |
| download | lwn-docs-6.1.tar.gz lwn-docs-6.1.zip | |
checkpatch: warn on usage of VM_BUG_ON() and other BUG variantsdocs-6.1
checkpatch does not point out that VM_BUG_ON() and friends should be
avoided, however, Linus notes:
VM_BUG_ON() has the exact same semantics as BUG_ON. It is literally
no different, the only difference is "we can make the code smaller
because these are less important". [1]
So let's warn on VM_BUG_ON() and other BUG variants as well. While at it,
make it clearer that the kernel really shouldn't be crashed.
As there are some subsystem BUG macros that actually don't end up crashing
the kernel -- for example, KVM_BUG_ON() -- exclude these manually.
[1] https://lore.kernel.org/r/CAHk-=wg40EAZofO16Eviaj7mfqDhZ2gVEbvfsMf6gYzspRjYvw@mail.gmail.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20220923113426.52871-3-david@redhat.com
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'fs/attr.c')
0 files changed, 0 insertions, 0 deletions