diff options
| author | Martin Kelly <mkelly@xevo.com> | 2017-12-05 10:34:03 -0800 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2017-12-08 10:45:11 +0100 |
| commit | c7f33023308f3142433b7379718af5f0c2c322a6 (patch) | |
| tree | 41e92dbb68dae37e1a89954aeb1cc3530e9e062c /drivers | |
| parent | 195bd525d5f6e338b948d9a6b25bfaae86291353 (diff) | |
| download | lwn-c7f33023308f3142433b7379718af5f0c2c322a6.tar.gz lwn-c7f33023308f3142433b7379718af5f0c2c322a6.zip | |
can: mcba_usb: cancel urb on -EPROTO
When we unplug the device, we can see both -EPIPE and -EPROTO depending
on exact timing and what system we run on. If we continue to resubmit
URBs, they will immediately fail, and they can cause stalls, especially
on slower CPUs.
Fix this by not resubmitting on -EPROTO, as we already do on -EPIPE.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/can/usb/mcba_usb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index ef417dcddbf7..8d8c2086424d 100644 --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -593,6 +593,7 @@ static void mcba_usb_read_bulk_callback(struct urb *urb) case -ENOENT: case -EPIPE: + case -EPROTO: case -ESHUTDOWN: return; |