summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorRiyan Dhiman <riyandhiman14@gmail.com>2024-09-01 23:52:44 +0530
committerUlf Hansson <ulf.hansson@linaro.org>2024-09-03 14:31:32 +0200
commit6f25e5deca7739a27462ef26fb5c07cfb926c4e4 (patch)
tree68356a3716fa2c2bd46cdd78584fc62fd4b1426a /drivers
parentd2253bfa830e907eddad13d9de99d7b6df8585a1 (diff)
downloadlwn-6f25e5deca7739a27462ef26fb5c07cfb926c4e4.tar.gz
lwn-6f25e5deca7739a27462ef26fb5c07cfb926c4e4.zip
mmc: core: Convert simple_stroul to kstroul
simple_strtoul() is obsolete and lacks proper error handling, making it unsafe for converting strings to unsigned long values. Replace it with kstrtoul(), which provides robust error checking and better safety. This change improves the reliability of the string-to-integer conversion and aligns with current kernel coding standards. Error handling is added to catch conversion failures, returning -EINVAL when input is invalid. Issue reported by checkpatch: - WARNING: simple_strtoul is obsolete, use kstrtoul instead Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com> Link: https://lore.kernel.org/r/20240901182244.45543-1-riyandhiman14@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/mmc/core/block.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 2ff053f2be11..f58bea534004 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -353,10 +353,10 @@ static ssize_t force_ro_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
int ret;
- char *end;
struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
- unsigned long set = simple_strtoul(buf, &end, 0);
- if (end == buf) {
+ unsigned long set;
+
+ if (kstrtoul(buf, 0, &set)) {
ret = -EINVAL;
goto out;
}