diff options
| author | Logan Gunthorpe <logang@deltatee.com> | 2019-01-09 12:22:27 -0700 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2020-06-05 20:02:08 -0400 |
| commit | 40da7d9a93c8941737ef4a1208d32c13ce017fe1 (patch) | |
| tree | 7c936e99bb7cca5da422ba3481d5049f89c1d698 /drivers | |
| parent | 912e12813dd03c602e4922fc34709ec4d4380cf0 (diff) | |
| download | lwn-40da7d9a93c8941737ef4a1208d32c13ce017fe1.tar.gz lwn-40da7d9a93c8941737ef4a1208d32c13ce017fe1.zip | |
NTB: Revert the change to use the NTB device dev for DMA allocations
Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB
devices") started using the NTB device for DMA allocations which was
turns out was wrong. If the IOMMU is enabled, such alloctanions will
always fail with messages such as:
DMAR: Allocating domain for 0000:02:00.1 failed
This is because the IOMMU has not setup the device for such use.
Change the tools back to using the PCI device for allocations seeing
it doesn't make sense to add an IOMMU group for the non-physical NTB
device. Also remove the code that sets the DMA mask as it no longer
makes sense to do this.
Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Tested-by: Alexander Fomichev <fomichev.ru@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ntb/core.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ntb/core.c b/drivers/ntb/core.c index 2581ab724c34..dc82be2dcf47 100644 --- a/drivers/ntb/core.c +++ b/drivers/ntb/core.c @@ -315,4 +315,3 @@ static void __exit ntb_driver_exit(void) bus_unregister(&ntb_bus); } module_exit(ntb_driver_exit); - |