diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-09-11 17:42:34 +0800 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2024-09-27 10:47:53 +0200 |
| commit | 09573b1cc76e7ff8f056ab29ea1cdc152ec8c653 (patch) | |
| tree | 45ad86897526cf91826f2eef9c0e73eed4d2d29a /drivers | |
| parent | bff1709b3980bd7f80be6786f64cc9a9ee9e56da (diff) | |
| download | lwn-09573b1cc76e7ff8f056ab29ea1cdc152ec8c653.tar.gz lwn-09573b1cc76e7ff8f056ab29ea1cdc152ec8c653.zip | |
net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.
Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/20240911094234.1922418-1-ruanjinjie@huawei.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ieee802154/mcr20a.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 433fb5839203..020d392a98b6 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi) irq_type = IRQF_TRIGGER_FALLING; ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr, - irq_type, dev_name(&spi->dev), lp); + irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp); if (ret) { dev_err(&spi->dev, "could not request_irq for mcr20a\n"); ret = -ENODEV; goto free_dev; } - /* disable_irq by default and wait for starting hardware */ - disable_irq(spi->irq); - ret = ieee802154_register_hw(hw); if (ret) { dev_crit(&spi->dev, "ieee802154_register_hw failed\n"); |