diff options
| author | Nikunj A Dadhania <nikunj@amd.com> | 2024-07-31 20:37:55 +0530 |
|---|---|---|
| committer | Borislav Petkov (AMD) <bp@alien8.de> | 2024-08-27 10:35:38 +0200 |
| commit | 2b9ac0b84c2cae91bbaceab62df4de6d503421ec (patch) | |
| tree | 0716e35d00856c21928c910d5280cb9016eb3448 /drivers/virt/coco | |
| parent | 5f7c38f81df206b370d97a827251bd4bc50ff46b (diff) | |
| download | lwn-2b9ac0b84c2cae91bbaceab62df4de6d503421ec.tar.gz lwn-2b9ac0b84c2cae91bbaceab62df4de6d503421ec.zip | |
virt: sev-guest: Ensure the SNP guest messages do not exceed a page
Currently, struct snp_guest_msg includes a message header (96 bytes) and
a payload (4000 bytes). There is an implicit assumption here that the
SNP message header will always be 96 bytes, and with that assumption the
payload array size has been set to 4000 bytes - a magic number. If any
new member is added to the SNP message header, the SNP guest message
will span more than a page.
Instead of using a magic number for the payload, declare struct
snp_guest_msg in a way that payload plus the message header do not
exceed a page.
[ bp: Massage. ]
Suggested-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240731150811.156771-5-nikunj@amd.com
Diffstat (limited to 'drivers/virt/coco')
| -rw-r--r-- | drivers/virt/coco/sev-guest/sev-guest.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c index 3b76cbf78f41..89754b019be2 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -1092,6 +1092,8 @@ static int __init sev_guest_probe(struct platform_device *pdev) void __iomem *mapping; int ret; + BUILD_BUG_ON(sizeof(struct snp_guest_msg) > PAGE_SIZE); + if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) return -ENODEV; |