diff options
| author | AlbertoArostegui <aarosteguig@gmail.com> | 2026-05-27 15:39:13 +0000 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2026-06-09 16:00:10 +0200 |
| commit | 91ffa533ac4dbf43050b4049be83456fed333f37 (patch) | |
| tree | e551bf0f15879e0f9d3250a2b8a86708876f063a /drivers/video/fbdev | |
| parent | 7b8055831c1796d2be7eeeb00d4513f497c8390d (diff) | |
| download | lwn-91ffa533ac4dbf43050b4049be83456fed333f37.tar.gz lwn-91ffa533ac4dbf43050b4049be83456fed333f37.zip | |
fbdev: pxa168fb: use devm_ioremap_resource() for MMIO
pxa168fb maps the LCD controller register resource with devm_ioremap(),
which does not request the memory region. Use devm_ioremap_resource()
instead so the MMIO range is claimed before being mapped.
This also handles cleanup automatically.
Signed-off-by: AlbertoArostegui <aarosteguig@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev')
| -rw-r--r-- | drivers/video/fbdev/pxa168fb.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index ec602f7776eb..6784888d93c9 100644 --- a/drivers/video/fbdev/pxa168fb.c +++ b/drivers/video/fbdev/pxa168fb.c @@ -653,10 +653,9 @@ static int pxa168fb_probe(struct platform_device *pdev) /* * Map LCD controller registers. */ - fbi->reg_base = devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (fbi->reg_base == NULL) { - ret = -ENOMEM; + fbi->reg_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(fbi->reg_base)) { + ret = PTR_ERR(fbi->reg_base); goto failed_free_info; } |