diff options
| author | Johan Hovold <johan@kernel.org> | 2020-01-16 17:07:05 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-01-17 11:11:26 +0100 |
| commit | fdb838efa31e1ed9a13ae6ad0b64e30fdbd00570 (patch) | |
| tree | bee2c0a59c13b0541ca708db04de284c3fc64139 /drivers/usb | |
| parent | f3eaabbfd093c93d791eb930cc68d9b15246a65e (diff) | |
| download | lwn-fdb838efa31e1ed9a13ae6ad0b64e30fdbd00570.tar.gz lwn-fdb838efa31e1ed9a13ae6ad0b64e30fdbd00570.zip | |
USB: serial: suppress driver bind attributes
USB-serial drivers must not be unbound from their ports before the
corresponding USB driver is unbound from the parent interface so
suppress the bind and unbind attributes.
Unbinding a serial driver while it's port is open is a sure way to
trigger a crash as any driver state is released on unbind while port
hangup is handled on the parent USB interface level. Drivers for
multiport devices where ports share a resource such as an interrupt
endpoint also generally cannot handle individual ports going away.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/usb-serial.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 8f066bb55d7d..dc7a65b9ec98 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -1317,6 +1317,9 @@ static int usb_serial_register(struct usb_serial_driver *driver) return -EINVAL; } + /* Prevent individual ports from being unbound. */ + driver->driver.suppress_bind_attrs = true; + usb_serial_operations_init(driver); /* Add this device to our list of devices */ |