diff options
| author | Wang Yufen <wangyufen@huawei.com> | 2022-11-26 22:35:32 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-06 16:37:00 +0100 |
| commit | 0376aa62320cab35d8532629fdf9cd3b8cb66c8d (patch) | |
| tree | 3f6057e00254d61985520d415575294de4175efc /drivers/usb/musb/da8xx.c | |
| parent | b566d38857fcb6777f25b674b90a831eec0817a2 (diff) | |
| download | lwn-0376aa62320cab35d8532629fdf9cd3b8cb66c8d.tar.gz lwn-0376aa62320cab35d8532629fdf9cd3b8cb66c8d.zip | |
usb: musb: fix error return code in da8xx_musb_init()
Fix to return a negative error code -ENODEV instead of 0 as before
commit 09721ba6daa1 ("usb: musb: da8xx: Call earlier
clk_prepare_enable()") did.
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1669473332-14165-1-git-send-email-wangyufen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/musb/da8xx.c')
| -rw-r--r-- | drivers/usb/musb/da8xx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index a4e55b0c52cf..d47e5c94587b 100644 --- a/drivers/usb/musb/da8xx.c +++ b/drivers/usb/musb/da8xx.c @@ -368,8 +368,10 @@ static int da8xx_musb_init(struct musb *musb) /* Returns zero if e.g. not clocked */ rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG); - if (!rev) + if (!rev) { + ret = -ENODEV; goto fail; + } musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR_OR_NULL(musb->xceiv)) { |