diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2023-01-30 20:06:33 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-31 10:39:03 +0100 |
| commit | 21ef9c91f0ab4f11d31fddbdc6d886fed114be74 (patch) | |
| tree | 8b12c93b3aaa219ed87f392c8213851aa20e3064 /drivers/usb/fotg210 | |
| parent | 8cb9c36b812591e36405708d0ee693b1c135fcbd (diff) | |
| download | lwn-21ef9c91f0ab4f11d31fddbdc6d886fed114be74.tar.gz lwn-21ef9c91f0ab4f11d31fddbdc6d886fed114be74.zip | |
usb: fotg210: fix return value check in fotg210_probe()
devm_platform_get_and_ioremap_resource() never returns NULL pointer,
it will return ERR_PTR() when it fails, so replace the check with
IS_ERR().
Fixes: baef5330d35b ("usb: fotg210: Acquire memory resource in core")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230130120633.3342285-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/fotg210')
| -rw-r--r-- | drivers/usb/fotg210/fotg210-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/fotg210/fotg210-core.c b/drivers/usb/fotg210/fotg210-core.c index 202d80adca2c..cb75464ab290 100644 --- a/drivers/usb/fotg210/fotg210-core.c +++ b/drivers/usb/fotg210/fotg210-core.c @@ -136,8 +136,8 @@ static int fotg210_probe(struct platform_device *pdev) fotg->dev = dev; fotg->base = devm_platform_get_and_ioremap_resource(pdev, 0, &fotg->res); - if (!fotg->base) - return -ENOMEM; + if (IS_ERR(fotg->base)) + return PTR_ERR(fotg->base); fotg->pclk = devm_clk_get_optional_enabled(dev, "PCLK"); if (IS_ERR(fotg->pclk)) |