summaryrefslogtreecommitdiff
path: root/drivers/usb/cdns3/cdns3-ep0.c
diff options
context:
space:
mode:
authorNiklas Cassel <cassel@kernel.org>2025-03-17 18:03:49 +0100
committerNiklas Cassel <cassel@kernel.org>2025-03-18 10:11:28 +0100
commitf2aac4c73c9945cce156fd58a9a2f31f2c8a90c7 (patch)
tree3d33152a180ff290dc9baaa6334f0686b1dd01c6 /drivers/usb/cdns3/cdns3-ep0.c
parenta2f925a2f62254119cdaa360cfc9c0424bccd531 (diff)
downloadlwn-f2aac4c73c9945cce156fd58a9a2f31f2c8a90c7.tar.gz
lwn-f2aac4c73c9945cce156fd58a9a2f31f2c8a90c7.zip
ata: libata-core: Add ATA_QUIRK_NO_LPM_ON_ATI for certain Samsung SSDs
Before commit 7627a0edef54 ("ata: ahci: Drop low power policy board type") the ATI AHCI controllers specified board type 'board_ahci' rather than board type 'board_ahci'. This means that LPM was historically not enabled for the ATI AHCI controllers. By looking at commit 7a8526a5cd51 ("libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD."), it is clear that, for some unknown reason, that Samsung SSDs do not play nice with ATI AHCI controllers. (When using other AHCI controllers, NCQ can be enabled on these Samsung SSDs without issues.) In a similar way, from user reports, it is clear the ATI AHCI controllers can enable LPM on e.g. Maxtor HDDs perfectly fine, but when enabling LPM on certain Samsung SSDs, things break. (E.g. the SSDs will not get detected by the ATI AHCI controller even after a COMRESET.) Yet, when using LPM on these Samsung SSDs with other AHCI controllers, e.g. Intel AHCI controllers, these Samsung drives appear to work perfectly fine. Considering that the combination of ATI + Samsung, for some unknown reason, does not seem to work well, disable LPM when detecting an ATI AHCI controller with a problematic Samsung SSD. Apply this new ATA_QUIRK_NO_LPM_ON_ATI quirk for all Samsung SSDs that have already been reported to not play nice with ATI (ATA_QUIRK_NO_NCQ_ON_ATI). Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type") Suggested-by: Hans de Goede <hdegoede@redhat.com> Reported-by: Eric <eric.4.debian@grabatoulnz.fr> Closes: https://lore.kernel.org/linux-ide/Z8SBZMBjvVXA7OAK@eldamar.lan/ Tested-by: Eric <eric.4.debian@grabatoulnz.fr> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20250317170348.1748671-2-cassel@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-ep0.c')
0 files changed, 0 insertions, 0 deletions